Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_4_071: PBL_utils atmospheric_physics integration #1235

Conversation

mwaxmonsky
Copy link
Collaborator

Integrated pbl_utils API moved into atmospheric_physics. Removes current pbl_utils.F90 API except for compute_radf(...).

@mwaxmonsky mwaxmonsky requested a review from nusbaume February 10, 2025 15:30
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this back into CAM @mwaxmonsky! It looks like there are some updates that need to happen now that the atmospheric_physics PR has been merged, but otherwise everything else looks good.

@mwaxmonsky mwaxmonsky requested a review from nusbaume February 24, 2025 20:59
@mwaxmonsky
Copy link
Collaborator Author

@nusbaume I just kicked off another round of regressions with a clean clone/checkout of the branch so hopefully nothing else breaks during the regressions but if it does, I'll update you. Otherwise, this should be good to go now!

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me now. Thanks again @mwaxmonsky!

@cacraigucar cacraigucar changed the title PBL_utils atmospheric_physics integration cam6_4_071: PBL_utils atmospheric_physics integration Feb 26, 2025
@mwaxmonsky mwaxmonsky merged commit d7080a1 into ESCOMP:cam_development Feb 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

2 participants